Skip to content

fix(builder): resolve property clearing glitches and improve horizontal layout (#55) #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ladparth merged 1 commit into from
Feb 23, 2026
Merged

fix(builder): resolve property clearing glitches and improve horizontal layout (#55) #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/web/app/(builder)/lib/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,10 @@ function mergeUpdates<T extends object>(target: T, source: Partial<T>) {
!Array.isArray(targetValue)
) {
mergeUpdates(targetValue as object, sourceValue as object);
} else if (sourceValue !== undefined) {
} else if (sourceValue === undefined) {
// Explicitly cleared — remove the key so field defaults take effect
delete target[key];
} else {
target[key] = sourceValue as T[keyof T];
}
}
Expand Down
8 changes: 4 additions & 4 deletions apps/web/registry/base/fields/checkbox-group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ function getOptionGroupLayoutClassName({
columns?: OptionGroupColumns;
}) {
const usesGridColumns = variant === "card" || direction === "horizontal";
const effectiveColumns = usesGridColumns ? columns : undefined;
// Default to 2 columns for horizontal direction so users see immediate feedback
const effectiveColumns = usesGridColumns
? (columns ?? (direction === "horizontal" ? 2 : undefined))
: undefined;

if (!effectiveColumns || effectiveColumns === 1) {
if (variant === "default" && direction === "horizontal") {
return "flex flex-wrap gap-x-4 gap-y-2";
}
return "flex flex-col gap-2";
}

Expand Down
8 changes: 4 additions & 4 deletions apps/web/registry/base/fields/radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ function getOptionGroupLayoutClassName({
columns?: OptionGroupColumns;
}) {
const usesGridColumns = variant === "card" || direction === "horizontal";
const effectiveColumns = usesGridColumns ? columns : undefined;
// Default to 2 columns for horizontal direction so users see immediate feedback
const effectiveColumns = usesGridColumns
? (columns ?? (direction === "horizontal" ? 2 : undefined))
: undefined;

if (!effectiveColumns || effectiveColumns === 1) {
if (variant === "default" && direction === "horizontal") {
return "flex flex-wrap gap-x-4 gap-y-2";
}
return "flex flex-col gap-2";
}

Expand Down
Loading