Add support for Platform 0.10 by natalieparellano · Pull Request #1547 · buildpacks/pack

natalieparellano · 2022-11-08T22:03:30Z

Summary

This PR builds off of #1478 so will probably be easier to review when that is merged

Supersedes #1527 (but keep that one open until we release pack with these changes as the docs PR points to #1527)

Still a draft because:

We need to update go.mod and the default lifecycle to 0.15.1 when released
We need to add unit tests for pack inspect for platform API >= 0.10

Documentation

Should this change be documented?
- Yes, see #___
- No

Fix (restore): when gid is provided, it shouldn't override other flags Fix (analyze): when cache image is used, flags should not also contain -cache-dir Fix (restore): when cache image is used, flags should not also contain -cache-dir - Variable rename (ops for operations) Fix (restore): provide registry credentials when using a cache image Signed-off-by: Natalie Arellano <narellano@vmware.com>

- 0.10 is a supported platform and the default lifecycle is 0.15.0 - Run the extender when there are extensions Signed-off-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Natalie Arellano <narellano@vmware.com>

CODEOWNERS

Signed-off-by: Natalie Arellano <narellano@vmware.com>

- The sha changed with the removal of *.bat (as Windows is not supported) Signed-off-by: Natalie Arellano <narellano@vmware.com>

… needed - On platform 0.10, we can't determine the buildpack API so we don't know how to display the process args; this should be fixed in platform 0.11 Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano · 2022-11-10T19:36:14Z

This is ready for review but needs to be re-pointed when extensions-phase-1 is merged as it is based off of that PR.

…on is not running Signed-off-by: Natalie Arellano <narellano@vmware.com>

Signed-off-by: Natalie Arellano <narellano@vmware.com>

… perms on Linux Signed-off-by: Natalie Arellano <narellano@vmware.com>

codecov · 2022-11-14T20:49:16Z

Codecov Report

Merging #1547 (6c3de7f) into main (007306f) will increase coverage by 0.15%.
The diff coverage is 85.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1547      +/-   ##
==========================================
+ Coverage   80.99%   81.14%   +0.15%     
==========================================
  Files         156      156              
  Lines       10284    10362      +78     
==========================================
+ Hits         8329     8407      +78     
  Misses       1458     1458              
  Partials      497      497

Flag	Coverage Δ
os_linux	`79.93% <82.42%> (+0.16%)`	⬆️
os_macos	`77.42% <82.42%> (+0.12%)`	⬆️
os_windows	`81.02% <85.72%> (+0.15%)`	⬆️
unit	`81.14% <85.72%> (+0.15%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Natalie Arellano <narellano@vmware.com>

We can't remove something that wasn't built Signed-off-by: Natalie Arellano <narellano@vmware.com>

jjbustamante

LGTM ❤️

dfreilich

Looks really good! Overall, I think it could've used a bit more clarification in the code about why there were so many specific kaniko changes, but I assume that's covered in RFC.

dfreilich · 2022-11-20T17:47:09Z

Makefile

 mod-tidy:
-	$(GOCMD) mod tidy
-	cd tools && $(GOCMD) mod tidy
+	$(GOCMD) mod tidy  -compat=1.17


nit: I'm not sure whether we need to ensure we have compat with go1.17. I would be fine in a future release migrating to >= go1.19, unless there are specific reasons for us to remain below latest

dfreilich · 2022-11-20T17:48:34Z

acceptance/testdata/mock_buildpacks/0.2/read-env-extension/extension.toml

@@ -1,4 +1,4 @@
-api = "0.2"
+api = "0.9"


Good catch, crazy we haven't bumped that version since!

dfreilich · 2022-11-20T17:49:32Z

go.mod


 go 1.17
+
+// Ensure compatibility with lifecycle/kaniko; match dependencies configured in:


Thanks for the note! Very helpful to have that added for the context

Natalie Arellano added 4 commits November 4, 2022 12:28

Merge branch 'main' into platform-0.10

6f3eab3

Add support for platform 0.10

8014240

- 0.10 is a supported platform and the default lifecycle is 0.15.0 - Run the extender when there are extensions Signed-off-by: Natalie Arellano <narellano@vmware.com>

Fix pack inspect for newer platform now that command is an array

4600666

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano changed the base branch from main to extensions-phase-1 November 8, 2022 22:03

github-actions bot added this to the 0.28.0 milestone Nov 8, 2022

github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Nov 8, 2022

natalieparellano commented Nov 8, 2022

View reviewed changes

CODEOWNERS Show resolved Hide resolved

Natalie Arellano added 3 commits November 8, 2022 17:18

Fix nesting in acceptance_test.go

4b32779

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Update sha for extension fixture

b042e7f

- The sha changed with the removal of *.bat (as Windows is not supported) Signed-off-by: Natalie Arellano <narellano@vmware.com>

Remove platform API information from image info as it's not currently…

078a339

… needed - On platform 0.10, we can't determine the buildpack API so we don't know how to display the process args; this should be fixed in platform 0.11 Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano marked this pull request as ready for review November 10, 2022 19:36

natalieparellano requested a review from a team as a code owner November 10, 2022 19:36

Base automatically changed from extensions-phase-1 to main November 14, 2022 14:30

jkutner requested a review from a team as a code owner November 14, 2022 14:30

Natalie Arellano added 4 commits November 14, 2022 10:38

Merge branch 'main' into platform-0.10

40221cb

Fix units: lifecycle execution tests should pass when the docker daem…

a919606

…on is not running Signed-off-by: Natalie Arellano <narellano@vmware.com>

Fix units: update Windows fixture for Windows test (not Linux)

dd35efe

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Try to fix extension.toml in acceptance

552f56a

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano force-pushed the platform-0.10 branch from e36292a to 85056f3 Compare November 14, 2022 17:58

Fix acceptance: update fixture sha now that fixture changed

d548169

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano force-pushed the platform-0.10 branch from 85056f3 to d548169 Compare November 14, 2022 18:03

natalieparellano mentioned this pull request Nov 14, 2022

pack inspect when image built with extensions should show the extensions #1486

Closed

Fix compat

07eabaf

Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano force-pushed the platform-0.10 branch 2 times, most recently from 8734390 to 203bbd5 Compare November 14, 2022 20:32

Fix acceptance: ensure extensions directory is created with the right…

cc7c00b

… perms on Linux Signed-off-by: Natalie Arellano <narellano@vmware.com>

natalieparellano force-pushed the platform-0.10 branch from 203bbd5 to cc7c00b Compare November 14, 2022 20:38

Natalie Arellano added 2 commits November 14, 2022 16:04

Fix compat: skip extensions test if lifecycle does not support it

805b72d

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Fix acceptance: fix cleanup

30272c4

We can't remove something that wasn't built Signed-off-by: Natalie Arellano <narellano@vmware.com>

jjbustamante approved these changes Nov 18, 2022

View reviewed changes

dfreilich approved these changes Nov 20, 2022

View reviewed changes

Merge branch 'main' into platform-0.10

6c3de7f

dfreilich enabled auto-merge November 20, 2022 18:01

dfreilich merged commit 2c64d8c into main Nov 20, 2022

dfreilich deleted the platform-0.10 branch November 20, 2022 18:22

dfreilich mentioned this pull request Nov 21, 2022

build(deps): bump github.com/buildpacks/lifecycle from 0.14.2 to 0.15.0 #1545

Closed

natalieparellano mentioned this pull request Dec 2, 2022

[RFC #0093] Update process types in inspect-image output to support command slice #1260

Closed

natalieparellano mentioned this pull request Dec 16, 2022

Support for pack build with extensions (platform 0.10) #1527

Closed

2 tasks

natalieparellano mentioned this pull request Mar 6, 2023

[RFC #0105] pack should support run image extension #1620

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Platform 0.10#1547

Add support for Platform 0.10#1547
dfreilich merged 17 commits intomainfrom
platform-0.10

natalieparellano commented Nov 8, 2022

Uh oh!

Uh oh!

natalieparellano commented Nov 10, 2022

Uh oh!

codecov bot commented Nov 14, 2022 •

edited

Loading

Uh oh!

jjbustamante left a comment

Uh oh!

dfreilich left a comment

Uh oh!

dfreilich Nov 20, 2022

Uh oh!

dfreilich Nov 20, 2022

Uh oh!

dfreilich Nov 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		go 1.17

		// Ensure compatibility with lifecycle/kaniko; match dependencies configured in:

Conversation

natalieparellano commented Nov 8, 2022

Summary

Documentation

Related

Uh oh!

Uh oh!

natalieparellano commented Nov 10, 2022

Uh oh!

codecov bot commented Nov 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jjbustamante left a comment

Choose a reason for hiding this comment

Uh oh!

dfreilich left a comment

Choose a reason for hiding this comment

Uh oh!

dfreilich Nov 20, 2022

Choose a reason for hiding this comment

Uh oh!

dfreilich Nov 20, 2022

Choose a reason for hiding this comment

Uh oh!

dfreilich Nov 20, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Nov 14, 2022 •

edited

Loading