Fix: when running restore, provide creds for run image if there are r…#1815
Merged
Fix: when running restore, provide creds for run image if there are r…#1815
Conversation
github-actions
bot
added
the
type/enhancement
Member
Author
|
Will undraft once tests are added |
…un image extensions Otherwise the restorer could fail to find the run image, resulting in unexpected behavior Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
fix/creds-for-run-ext
branch
from
3da1c01 to
8c5813d
Compare
Member
Author
|
See buildpacks/lifecycle#1134 (comment) for further evidence that this fix does what it is supposed to |
…t was only switched and we don't need to run extend) as the restorer also needs to update the digest & target data. Signed-off-by: Natalie Arellano <narellano@vmware.com>
jkutner
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…un image extensions
Otherwise the restorer could fail to find the run image, resulting in unexpected behavior
Summary
Output
Before
After
Documentation
Related
Resolves #___