Fix registryPattern to support registry names with port numbers#2550
Open
alexchenai wants to merge 1 commit intobuildpacks:mainfrom
Open
Fix registryPattern to support registry names with port numbers#2550alexchenai wants to merge 1 commit intobuildpacks:mainfrom
alexchenai wants to merge 1 commit intobuildpacks:mainfrom
Conversation
The registryPattern regex did not account for port numbers in registry references (e.g., localhost:5000/namespace/name), causing canBeRegistryRef to return false for valid registry URIs that include ports. Add an optional port number group (?:[0-9]+)? to the regex pattern. Fixes buildpacks#2536
github-actions
bot
added
the
type/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canBeRegistryRefreturning false for valid registry references that include port numbers (e.g.,localhost:5000/namespace/name)(?:[0-9]+)?to theregistryPatternregexFixes #2536
Test plan
localhost:5000/fooandmyregistry:8080/barare recognized asRegistryLocator