fix: handle all OS/arch combinations in uriFromLifecycleVersion#2551
Open
mvanhorn wants to merge 1 commit intobuildpacks:mainfrom
Open
fix: handle all OS/arch combinations in uriFromLifecycleVersion#2551mvanhorn wants to merge 1 commit intobuildpacks:mainfrom
mvanhorn wants to merge 1 commit intobuildpacks:mainfrom
Conversation
- Add FreeBSD support with amd64 and arm64 architectures - Cap Windows lifecycle version at v0.20.5 (deprecated) with warning - Replace SupportedLinuxArchitecture check with per-OS arch mappers - Map amd64 alias correctly per OS (x86-64 on Linux/Windows, amd64 on FreeBSD) Fixes buildpacks#2546
github-actions
bot
added
the
type/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
uriFromLifecycleVersionto correctly handle all OS/architecture combinations that the lifecycle project publishes binaries for.Why this matters
Three issues existed in the URL builder (#2546):
amd64vsx86-64) differed by OS but were only handled for LinuxChanges
pkg/client/create_builder.go: RewroteuriFromLifecycleVersionwith aswitchon OS. AddedlinuxArch,freebsdArch, andwindowsArchhelpers that map input architectures to the correct binary suffix per OS. Windows now caps at v0.20.5 with a deprecation warning.internal/builder/lifecycle.go: AddedSupportedFreeBSDArchitecturefor consistency with the existingSupportedLinuxArchitecture.Architecture mapping per OS
Fixes #2546
This contribution was developed with AI assistance (Claude Code).