Fix a crash in the Cronet integration when handling empty responses.#5719
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix a crash in the Cronet integration when handling empty responses.#5719copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
The logic in BufferQueue was incorrectly identifying identity/uncompressed
responses as compressed, and vice versa. Additionally, for empty responses
(Content-Length: 0), it could attempt to allocate a 0-capacity buffer, which
causes Cronet to throw an IllegalArgumentException ("ByteBuffer is already full").
This change:
- Corrects the inverted logic (renaming `isCompressed` to `isIdentity`).
- Ensures we always allocate a buffer of at least size 1 even for empty responses.
PiperOrigin-RevId: 943906033
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a crash in the Cronet integration when handling empty responses.
The logic in BufferQueue was incorrectly identifying identity/uncompressed
responses as compressed, and vice versa. Additionally, for empty responses
(Content-Length: 0), it could attempt to allocate a 0-capacity buffer, which
causes Cronet to throw an IllegalArgumentException ("ByteBuffer is already full").
This change:
isCompressedtoisIdentity).