Use globalThis with polyfill to get global object#33
Open
renchap wants to merge 1 commit intobwindels:masterfrom
Open
Use globalThis with polyfill to get global object#33renchap wants to merge 1 commit intobwindels:masterfrom
globalThis with polyfill to get global object#33renchap wants to merge 1 commit intobwindels:masterfrom
Conversation
Currently this library uses `eval()` to get the global object, but this does not work when using a CSP policy not allowing `eval`. There is a stage 3 ECMAscript proposal to create a `globalThis` object to achieve the same result, so lets use it and polyfill it when needed using https://github.com/ljharb/globalThis
Author
|
I tested this PR with my app (browser only) and it still works. Tests are passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this library uses
eval()to get the global object, but this does not work when using a CSP policy not allowingeval.There is a stage 3 ECMAscript proposal to create a
globalThisobject to achieve the same result, so lets use it and polyfill it when neededusing https://github.com/ljharb/globalThis