Open
Conversation
Contributor
|
Just a small thought. Maybe it makes more sense to keep CSV parsing outside this gem? (i.e. closing this without a merge) There is already support for custom backends, and I'm guessing JSON and YAML is enough for most people. Also, CSV has no support for data types and parsing them is much harder than JSON or YAML (there is no single CSV specification). (but I'm no maintainer, so the repo owner obviously decides) |
|
this is nice feature and can be useful on some projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need this feature for my own application.
Notice that we've added an additional "position" attribute, to take advantage of the fact that csvs are ordered.