feat(fm): copy/move between file-manager panes (MC F5/F6, increment B)#28
Merged
Conversation
The defining MC operation: F5 copies and F6 moves the selection (or the cursor row) into another file-manager pane — the two-panel workflow the integrated FM was always meant to support. - fm_registry.rs: a data-only singleton of live FM panes (id, live host:/path label, filesystem namespace, current dir). Each browser publishes its descriptor on every directory change and removes it on close — no view handles held, so no cross-view-borrow or handle lifecycle risk. Unit-tested upsert/remove/same-fs matching. - SftpBackend gains copy_file (+ a default recursive copy_dir): native std::fs copy for the local backend; the live SFTP backend round-trips bytes through a local temp via the proven streaming primitives (SFTP has no server-side copy). Move reuses rename (atomic on one fs). - F5/F6 pick the single other same-namespace pane automatically (the MC two-panel case); 0 or >1 candidates are reported, never guessed. Existing targets are skipped, never silently overwritten; the result (copied / skipped / failed → target) is toasted. Cross-connection (local<->remote) transfer stays a later increment. - F6 is now Move (MC parity); rename moves to F2 (kept keyboard-reachable and via the context menu). Verified: cargo check -p warp 0/0; 244 sftp + 3 registry + 6 keynav tests green (5 new end-to-end cross-pane copy/move/dir/guard/skip tests). No build triggered. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defining Midnight Commander operation, on top of #27's keyboard core: F5 copies and F6 moves the selection (or the cursor row) into another file-manager pane — the two-panel workflow the integrated FM was always meant to support.
What lands
fm_registry.rs— a data-only singleton of the live FM panes (id, livehost:/pathlabel, filesystem namespace, current dir). Each browser publishes its descriptor on every directory change and removes it on close. No view handles are held, so there's no cross-view-borrow or handle-lifecycle risk. Unit-tested upsert / remove / same-fs matching.SftpBackend::copy_file(+ a default recursivecopy_dir): nativestd::fscopy for the local backend; the live SFTP backend round-trips bytes through a local temp via the proven streaming primitives (SFTP has no server-side copy). Move reusesrename(atomic on one filesystem).copied / skipped / failed → target) is toasted.Honest scope: same-filesystem copy/move (two local panes, or two panes on the same host). Cross-connection local↔remote transfer (with progress/cancel) is the next increment — it reuses the existing SFTP transfer engine.
Verified:
cargo check -p warp0 errors/0 warnings; 244 sftp + 3 registry + 6 keynav tests green, including 5 new end-to-end tests (copy, move, recursive-dir copy, no-target guard, existing-target skip). No build triggered (per the standing no-build-without-substantial-progress rule).🤖 Generated with Claude Code