feat(fm): move across connections (F6 local↔remote)#30
Merged
Conversation
F6 now works between a local and a remote pane, not just same-fs: the file transfers (upload/download) and, only once that fully succeeds, the source is deleted through its own backend. The source is never removed on failure or cancellation, so a failed move cannot lose data. - spawn_transfer_with_backend gains delete_after = Some((source_backend, source_path)); the completion deletes the source on Ok(Ok(())) only. - transfer_cross_connection drops the move deferral and passes the delete intent per file; the summary reads "move transfer(s) started". Directories across connections and two-different-remote-hosts remain reported-not-done (the rest of increment C). Verified: cargo check -p warp 0/0; 248 sftp + 5 registry + 6 keynav tests green (the former deferral test now asserts the transfer starts). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes F6 (move) across connections on top of #29's cross-connection copy: moving a file between a local and a remote pane now transfers it, then — only once the transfer fully succeeds — deletes the source through its own backend. The source is never removed on failure or cancellation, so a failed move can't lose data.
spawn_transfer_with_backendgainsdelete_after = Some((source_backend, source_path)); the completion deletes the source onOk(Ok(()))only.transfer_cross_connectiondrops the move deferral and passes the delete intent per file.Still reported-not-done (the remainder of increment C): directories across connections, two different remote hosts, the >2-pane target picker, and overwrite-confirm.
Verified:
cargo check -p warp0/0; 248 sftp + 5 registry + 6 keynav tests green (the former deferral test now asserts the move transfer starts). No build triggered.🤖 Generated with Claude Code