feat(fm): F3/F4 open files in the editor (view/edit) — local#32
Merged
Conversation
F3 (View) / F4 (Edit) now open the file under the cursor in a code
editor pane instead of downloading it. A directory is entered as before.
- New WorkspaceAction::OpenFileInEditor { node_id, path }: local files
(empty node_id) open directly via add_tab_for_code_file (full view +
edit); remote files report that native editor integration is coming
rather than downloading a local copy that wouldn't save back.
- SftpBrowserView::open_cursor_in_editor dispatches it; F3/F4 (key + bar)
route here. Enter still activates (dir → navigate, file → download),
so Download stays available.
Scope: local files fully work. Remote view/edit is the honest follow-up
— the correct path is zaplex's native remote editor (buffer-sync via the
SSH daemon, saves back safely), which needs the file manager's SFTP host
resolved to the daemon HostId; a download-to-temp shortcut would risk
silent data loss on save and is deliberately avoided.
Verified: cargo check -p warp 0/0; 252 sftp tests green (1 new:
F3/F4 on a directory navigates).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F3 (View) / F4 (Edit) now open the file under the cursor in a code editor pane instead of downloading it. A directory is entered as before; Enter still activates (dir → navigate, file → download), so Download stays available.
WorkspaceAction::OpenFileInEditor { node_id, path }: local files open directly viaadd_tab_for_code_file(full view + edit); remote files report that native editor integration is coming rather than downloading a local copy that wouldn't save back.open_cursor_in_editordispatches it; F3/F4 (key + function bar) route here.Scope & honesty: local files fully work. Remote view/edit is the deliberate follow-up. The correct path is zaplex's native remote editor (
CodeSource::RemoteFileTree, buffer-sync via the SSH daemon — saves back safely), which requires resolving the file manager's SFTP host to the daemonHostId(two separate subsystems). A download-to-temp shortcut would risk silent data loss on save, so it's avoided; the remote case reports clearly for now.Verified:
cargo check -p warp0/0; 252 sftp tests green (1 new: F3/F4 on a directory navigates). No build triggered.🤖 Generated with Claude Code