Update component-init to published component-init-transform#159
Merged
Conversation
…wasmtime serve -Scli`
* eliminate dependency on wasm-convert * for the moment, using my branch of component-init. we should publish to crates.io once this is validated. * update to wasm-tools versions matching component-init * update wasmtime to latest, not required but just nice to do while we're here * eliminate wasi-common dependency, which is unnecessary
pchickey
changed the title
dicej
approved these changes
Jul 1, 2025
dicej
left a comment
dicej
left a comment
Collaborator
There was a problem hiding this comment.
Looks great; thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to use dicej/component-init#7 and dicej/component-init#10:
wasm-convert, swap out forwasm-encoder::reencode.component-initis now published on crates.io ascomponent-init-transform. Use the published crate.wasm-toolsversions matching component-initwasmtimeto latest, not required but just nice to do while we're herewasi-commondependency, which is unnecessarywasmtime serve -Scliinstead ofwasmtime serve --wasi common, this was just because I was double-checking that wasi-common wasnt actually used anywhere and I couldn't remember what that old way of doing the cli option even does. They are equivalent.