Fix possible data race in thread manager#1973
Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom Feb 20, 2023
Merged
Conversation
Merged
Contributor
|
Thanks, I just tested it and it fixes the problem I was seeing in #1971, let's merge it so that I can rebase my PR |
eloparco
approved these changes
Feb 20, 2023
eloparco
added a commit
to eloparco/wasm-micro-runtime
that referenced
this pull request
Feb 20, 2023
Collaborator
Author
Done. |
eloparco
added a commit
to eloparco/wasm-micro-runtime
that referenced
this pull request
Feb 20, 2023
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Destroy child thread's exec_env before destroying its module instance and add the process into cluster's lock to avoid possible data race: if exec_env is removed from custer's exec_env_list and destroyed later, the main thread may not wait it and start to destroy the wasm runtime, and the destroying of the sub thread's exec_env may free or overread/written an destroyed or re-initialized resource. And fix an issue in wasm_cluster_cancel_thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destroy child thread's exec_env before destroying its module instance and
add the process into cluster's lock to avoid possible data race: if exec_env
is removed from custer's exec_env_list and destroyed later, the main thread
may not wait it and start to destroy the wasm runtime, and the destroying
of the sub thread's exec_env may free or overwritten an destroyed or
re-initialized resource.
And fix an issue in wasm_cluster_cancel_thread.