Add/reorganize locks for thread synchronization#1995
Merged
wenyongh merged 13 commits intobytecodealliance:mainfrom Mar 4, 2023
Merged
Add/reorganize locks for thread synchronization#1995wenyongh merged 13 commits intobytecodealliance:mainfrom
wenyongh merged 13 commits intobytecodealliance:mainfrom
Conversation
…st, make list removal and wait info release atomic
eloparco
commented
Mar 1, 2023
eloparco
force-pushed
the
eloparco/add-locks-for-threads
branch
from
57d36e6 to
0c8da38
Compare
wenyongh
reviewed
Mar 1, 2023
eloparco
force-pushed
the
eloparco/add-locks-for-threads
branch
2 times, most recently
from
e9e549a to
1fa870b
Compare
eloparco
force-pushed
the
eloparco/add-locks-for-threads
branch
from
1fa870b to
df39af2
Compare
…f thread-unsafe exception retrievals
wenyongh
reviewed
Mar 2, 2023
Contributor
Author
|
While the changes in this PR seem to fix most of the race conditions shown by the thread sanitizer when running the tests in #1963, the test here is still failing https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/4308819396/jobs/7515771517 (and it's failing quite consistently also on my local machine). I though it was related to race conditions, but apparently that's not the case. |
eloparco
commented
Mar 2, 2023
eloparco
force-pushed
the
eloparco/add-locks-for-threads
branch
from
55c1652 to
3c5e092
Compare
eloparco
force-pushed
the
eloparco/add-locks-for-threads
branch
from
3c5e092 to
886fd62
Compare
wenyongh
reviewed
Mar 3, 2023
Collaborator
wenyongh
left a comment
wenyongh
left a comment
There was a problem hiding this comment.
LGTM, except several minor change suggestion.
Contributor
Author
|
Do not merge yet, I'm still running some tests to validate the changes |
Contributor
Author
|
I think we can merge it. I still see some edge cases remaining, but this PR should fix most data races |
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Mar 4, 2023
Add/reorganize locks for thread synchronization (bytecodealliance#1995)
Merged
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Attempt to fix data races when using threads. - Protect access (from multiple threads) to exception and memory - Fix shared memory lock usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix data races when using threads.