perf(wamrc): Replace slow symbol lookup with hash map in wamrc#4912
Open
jammar1 wants to merge 1 commit intobytecodealliance:mainfrom
Open
perf(wamrc): Replace slow symbol lookup with hash map in wamrc#4912jammar1 wants to merge 1 commit intobytecodealliance:mainfrom
jammar1 wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
…ion/emission The relocation symbol deduplication in aot_emit_aot_file.c used a linked list, requiring O(n) traversal per relocation to check for duplicates. Replace with a lazily-allocated hash map for O(1) lookups. The linked list is preserved for ordered iteration during emission.
jammar1
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace slow symbol lookup with hash map in AOT compilation.
The relocation symbol deduplication in aot_emit_aot_file.c used a linked list, requiring O(n) traversal per relocation to check for duplicates.
Replace with a lazily-allocated hash map for O(1) lookups. The linked list is preserved for ordered iteration during emission.
When testing against a fairly large Wasm binary (about 18MB) this reduced compilation time by about ~15%.