wasmtime-cli: component run's --invoke uses ItemName for search#13564
Open
pchickey wants to merge 3 commits into
Open
wasmtime-cli: component run's --invoke uses ItemName for search#13564pchickey wants to merge 3 commits into
pchickey wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forwards-compatible improvements to
wasmtime run --invokeon components:wit_parser::ItemNameas the parser for the function name in the wave expression (new in wasm-tools 251), look up viaExportLookup, both changes to make this possible introduced by wasmtime: impl ExportLookup for wit_parser::ItemName #13505