[stack-switching] Fix type index conflation in translation of switch - #14085
Open
dhil wants to merge 1 commit into
Open
[stack-switching] Fix type index conflation in translation of switch#14085dhil wants to merge 1 commit into
switch#14085dhil wants to merge 1 commit into
Conversation
…itch` The translation of `switch` would erroneously decompose a `ModuleInternedTypeIndex` and use its `u32` representation to build a `TypeIndex`. The two index types map different spaces, consequently it is possible to cause a compiler crash (out of bounds on lookup) or worse a runtime crash (argument types mismatch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this bug whilst working on fixing the interaction between GC and stack switching. I have hoisted it here as tiny self-contained PR.
The translation of
switchwould erroneously decompose aModuleInternedTypeIndexand use itsu32representation to build aTypeIndex. The two index types map different spaces, consequently it is possible to cause a compiler crash (out of bounds on lookup) or worse a runtime crash (argument types mismatch).