C#: Compilation failure if variant has same name as one of the cases. #1535
+32
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an underscore to the case name
dicej
reviewed
Feb 12, 2026
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
LGTM; would you mind adding a codegen test that covers this case?
Collaborator
Author
|
#1514 has the test case for this, so added the c++ exclusion as that is known to fail. |
dicej
approved these changes
Feb 12, 2026
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
Thanks! Looks like there's a conflict that needs to be resolved, but then this will be good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suffixes the variant case name with an underscore if it has the same name as the variant. Fixes issue 6 in #1515