fix: implement deallocation for fixed-length lists with heap elements #1538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
deallocatefunction in core ABI had atodo!()forFixedLengthList, panicking when flat deallocation was needed (e.g.,list<own<resource>, 3>)deallocate_indirectfunction was a silent no-op (=> {}), leaking memory for fixed-length lists containing heap-allocated elements like strings or nested listsflat_for_each_record_typewith repeated element types to iterate and deallocate each elementdeallocate_indirect_fieldswith a vec of repeated element types to correctly compute memory offsetsTest plan
cabi_post_deallocation functions are generated forlist<string, 3>exportsneeds_deallocatealready correctly returnstruefor fixed-length lists with complex elements — the fix ensures the deallocation instructions are actually emitted