fix(go): prevent GC finalizer on borrowed resource handles #1539
+74
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add wit-bindgen-core, wit-bindgen-rust, wit-bindgen-go, and wit-parser as workspace dev-dependencies to support integration test files.
FromBorrowHandle for imported resources was incorrectly delegating to FromOwnHandle, which registers a GC finalizer via runtime.AddCleanup. This violates the Component Model specification: borrowed handles are not owned by the callee, so the callee must not drop them. When Go's garbage collector ran, it would drop borrowed handles through the finalizer, corrupting the host's resource table. Fix FromBorrowHandle to create a handle object directly without registering a GC finalizer, preserving the correct ownership semantics.
sumleo
force-pushed
the
fix/go-borrow-handle
branch
from
4820b50 to
bb1d9f3
Compare
Member
|
Thanks! Would it be possible to move the test to something in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FromBorrowHandlefor imported resources was incorrectly delegating toFromOwnHandle, which registers a GC finalizer viaruntime.AddCleanupresourceDropon the borrowed handle, corrupting the host's resource tableFromBorrowHandleto create a handle object directly without registering a GC finalizer, preserving correct ownership semanticsTest plan
tests/go_borrow_handle.rsthat generates Go code for an imported resource withborrow<blob>parameterFromBorrowHandlefunction does NOT containFromOwnHandledelegation orAddCleanupcallsFromBorrowHandlefor exported resources (which correctly uses pointer-based rep without finalizer) is unchanged