Harden Sift filing and security checks#2
Draft
c0remusic wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The previous implementation could leave filesystem and SQLite state out of sync after partial failures. Tests could also pass while audio fixtures were missing, and the asset protocol exposed the full filesystem.
Impact
Filing and bin operations now fail safely, migrations cannot advance their version marker after a partial schema change, CI exercises the audio fixtures, and local media access is granted only for known tracks.
Validation
Existing debt
cargo clippy --all-targets -- -D warnings still reports six pre-existing warnings outside the changed lines. The repository also has pre-existing global rustfmt drift.