Skip to content

Harden Sift filing and security checks#2

Draft
c0remusic wants to merge 1 commit into
mainfrom
codex/sift-review-fixes
Draft

Harden Sift filing and security checks#2
c0remusic wants to merge 1 commit into
mainfrom
codex/sift-review-fixes

Conversation

@c0remusic

Copy link
Copy Markdown
Owner

What changed

  • make filing, trash, restore, purge, and migration updates transactional
  • compensate filesystem moves when database writes fail and surface rollback failures
  • require generated audio fixtures and run Rust tests in CI
  • restrict the Tauri asset protocol to database-known files and remove unsafe script CSP directives
  • add regression tests and a Tauri security-policy check

Why

The previous implementation could leave filesystem and SQLite state out of sync after partial failures. Tests could also pass while audio fixtures were missing, and the asset protocol exposed the full filesystem.

Impact

Filing and bin operations now fail safely, migrations cannot advance their version marker after a partial schema change, CI exercises the audio fixtures, and local media access is granted only for known tracks.

Validation

  • cargo test --manifest-path src-tauri/Cargo.toml: 129 tests passed
  • npx tsc --noEmit
  • npm run build
  • npm run check:tauri-security
  • git diff --check

Existing debt

cargo clippy --all-targets -- -D warnings still reports six pre-existing warnings outside the changed lines. The repository also has pre-existing global rustfmt drift.

@vercel

vercel Bot commented Jul 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dj-assistant Ready Ready Preview, Comment Jul 13, 2026 8:37am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant