fix: remove hardcoded keywords= suffix from form action#151
Open
shivv23 wants to merge 1 commit intoc2siorg:mainfrom
Open
fix: remove hardcoded keywords= suffix from form action#151shivv23 wants to merge 1 commit intoc2siorg:mainfrom
shivv23 wants to merge 1 commit intoc2siorg:mainfrom
Conversation
The form action now uses /news_keywords instead of /news_keywords?keywords= The form submits exactly one keywords parameter from user input. Closes c2siorg#117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove hardcoded
?keywords=suffix from form action URLs incontent.js. The form now submits exactly onekeywordsparameter from user input.Related Issues
Motivation and Context
The previous form actions had
?keywords=hardcoded which could cause empty leading keyword values when submitted.How Has This Been Tested
Checklist