Command Map recurse depending on flag; Filter do not recurse#1649
Closed
evgaster wants to merge 5 commits intoc3d:stablefrom
Closed
Command Map recurse depending on flag; Filter do not recurse#1649evgaster wants to merge 5 commits intoc3d:stablefrom
evgaster wants to merge 5 commits intoc3d:stablefrom
Conversation
With nested lists the commands Map and Filter operated not only on the top level list but recursively on the nested list(s) ... with the same provided rpl program. Removed the recursive processing of the elements of a list. Fixes: c3d#1648 Signed-off-by: Ed@vanGasteren.net
c3d
added a commit
that referenced
this pull request
Mar 9, 2026
The `map` function on the HP48 is supposed to be recursive. Document that fact. Related to #1649 Signed-off-by: Christophe de Dinechin <christophe@dinechin.org>
The HP 50g maps recursively. Most other programming languages map only on level. Introduce the flag MapRecursive / MapOneLevel. Both behaviours are now possible. Describes as such in the documentation. Fixes: c3d#1648 Signed-off-by: Ed@vanGasteren.net
In a Previous commit I got the default flag behaviour wrong. Fixes c3d#1648 Signed-off-by: Ed@vanGasteren.net
Fixes c3d#1648 Signed-off-by: Ed@vanGasteren.net
evgaster
changed the title
evgaster
changed the title
evgaster
changed the title
Signed-off-by: evgaster <Ed@vanGasteren.net>
Owner
|
Hi @evgaster. Thanks a lot for the PR. In the end, I rewrote it somewhat significantly to make it a bit more general.
|
Owner
|
Closing this for now, thanks a lot @evgaster |
c3d
pushed a commit
that referenced
this pull request
Apr 12, 2026
The `ListRecursionDepth` controls the recusion depth for the `map`, `reduce` and `filter` operation. This defaults to `1`, meaning that we apply these functions only to the top level of the lists. The idea derives from work in PR #1649, but generalizing the approach in the PR, which only had a binary setting, disabled recursion for `filter` entirely, and did not consider the case of `reduce`. Fixes: #1648 Signed-off-by: Christophe de Dinechin <christophe@dinechin.org> Suggested-by: Ed@vanGasteren.net
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With nested lists the commands Map and Filter operated not only on the top level list but recursively on the nested list(s) . The HP 50g map command also does this. The HP 50g has no filter command.
Most programming languages work on only the toplevel of a list and do not recurse
Introduced a MapRecursive / MapOneLevel flag to facilitate both behaviours.
The default behaviour of DB48x map corresponds to the HP 50g behaviour (MapRecursive = true).
The filter command no longer works recursively.
Fixes: #1648
Signed-off-by: Ed@vanGasteren.net