feat(#215): validate bluetooth address in populate_bluez_info & BluetoothIdentity::new#246
Merged
cachebag merged 4 commits intocachebag:masterfrom Feb 16, 2026
Merged
Conversation
cachebag
requested changes
Feb 15, 2026
| /// | ||
| /// # Errors | ||
| /// Returns `ConnectionError::InvalidAddress` if the Bluetooth address is invalid. | ||
| pub fn validate_bluetooth_address(bdaddr: &str) -> Result<(), ConnectionError> { |
Owner
There was a problem hiding this comment.
It's best we split and validate segments (I.e. a Vec of &str's for parts and then match on length)
Contributor
Author
There was a problem hiding this comment.
Modified the impl to check on each segment after splitting.
pluiee
force-pushed
the
pluie/bluetooth-validate
branch
from
9e01496 to
3b25849
Compare
Contributor
Author
|
I rebased after adding a commit to align with the updated master, but there seems to be a minor ci problem. |
cachebag
approved these changes
Feb 16, 2026
Owner
cachebag
left a comment
cachebag
left a comment
There was a problem hiding this comment.
Thank! Don't worry about CI I'm breaking things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #215 by implementing
validate_bluetooth_addressand applying it withinpopulate_bluez_infoandBluetoothIdentity::new. Note thatBluetoothDevice::newis out of scope since its input comes frompopulate_bluez_info, assuring the validity.