Renaming and cleanup #108
Merged
Renaming and cleanup #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmoelder
reviewed
Jan 27, 2026
schmoelder
reviewed
Jan 27, 2026
schmoelder
reviewed
Jan 27, 2026
schmoelder
reviewed
Jan 27, 2026
schmoelder
reviewed
Jan 27, 2026
Contributor
There was a problem hiding this comment.
I'm not super sensitive here (but maybe a little). Let's try to use the order of contribution.
Contributor
Author
There was a problem hiding this comment.
My dear Johannes, you should know best that I always sort in order of contributions :D You just made 16 commits this month and overtook me, so I am happy to fix that of course.
Contributor
Author
There was a problem hiding this comment.
Btw, neither Daniel nor me are mentioned in CADET-Process analogon to the AUTHORS.md, which is the CONTRIBUTORS.md there. :)
Contributor
There was a problem hiding this comment.
Then we should change that! ;-)
schmoelder
reviewed
Jan 27, 2026
schmoelder
reviewed
Jan 27, 2026
Contributor
schmoelder
left a comment
schmoelder
left a comment
There was a problem hiding this comment.
Generally looks good to me. Just some minor comments.
hannahlanzrath
force-pushed
the
renaming_and_cleanup
branch
2 times, most recently
from
916f468 to
fefd87e
Compare
Co-authored-by: Hannah Lanzrath <h.lanzrath@fz-juelich.de>
Applies naming conventions to comments, docs and variables. Co-authored-by: Hannah Lanzrath <h.lanzrath@fz-juelich.de>
Co-authored-by: Hannah Lanzrath <h.lanzrath@fz-juelich.de>
Co-authored-by: Hannah Lanzrath <h.lanzrath@fz-juelich.de>
hannahlanzrath
force-pushed
the
renaming_and_cleanup
branch
from
fefd87e to
fee25c6
Compare
schmoelder
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all changes from the original Documentation branch from Katha, that were not actually documentation. I have rebased it on main, and then rebased Kathas Documentation branch on this one here.
Kathas Documentation branch: