Skip to content

Update output repository before loading results#114

Merged
hannahlanzrath merged 1 commit intomainfrom
feat/update-before-loading
Feb 5, 2026
Merged

Update output repository before loading results#114
hannahlanzrath merged 1 commit intomainfrom
feat/update-before-loading

Conversation

@schmoelder
Copy link
Contributor

@schmoelder schmoelder commented Feb 5, 2026

This PR adds a call to output_repo.update() so that we always consider the latest results when loading from cache.

We could also make this optional via an argument, what do you think @hannahlanzrath?

Note, this builds upon #112

@hannahlanzrath hannahlanzrath force-pushed the feat/update-before-loading branch from a40c161 to c9427eb Compare February 5, 2026 16:00
@hannahlanzrath
Copy link
Contributor

hannahlanzrath commented Feb 5, 2026

Great thanks!

We could also make this optional via an argument, what do you think @hannahlanzrath?

In my head, I could not think of a good scenario where I would not want to have my up to date output repo when I load from cash, so I think I would leave it with your commit for now.

@schmoelder
Copy link
Contributor Author

In my case, I'm loading many cases at once, so it always checks and it does always take some seconds. But it's not a dealbreaker.

@hannahlanzrath
Copy link
Contributor

In my case, I'm loading many cases at once, so it always checks and it does always take some seconds. But it's not a dealbreaker.

Alright, then let's merge it and if it gets annoyingly slow let us think of solutions then!

@hannahlanzrath hannahlanzrath merged commit f35825d into main Feb 5, 2026
6 checks passed
@hannahlanzrath hannahlanzrath deleted the feat/update-before-loading branch February 5, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants