Update output repository before loading results#114
Merged
hannahlanzrath merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
a40c161 to
c9427eb
Compare
Contributor
|
Great thanks!
In my head, I could not think of a good scenario where I would not want to have my up to date output repo when I load from cash, so I think I would leave it with your commit for now. |
Contributor
Author
|
In my case, I'm loading many cases at once, so it always checks and it does always take some seconds. But it's not a dealbreaker. |
Contributor
Alright, then let's merge it and if it gets annoyingly slow let us think of solutions then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a call to
output_repo.update()so that we always consider the latest results when loading from cache.We could also make this optional via an argument, what do you think @hannahlanzrath?
Note, this builds upon #112