Skip to content

Added ability to save settings#1

Merged
caerulius merged 4 commits into
caerulius:masterfrom
Stochast1c:master
Feb 15, 2019
Merged

Added ability to save settings#1
caerulius merged 4 commits into
caerulius:masterfrom
Stochast1c:master

Conversation

@Stochast1c
Copy link
Copy Markdown

@Stochast1c Stochast1c commented Feb 11, 2019

Submitting request here since hotpocket doesn't seem to want to accept any requests.

Added a simple parser to save/read settings for future uses.

Also includes a better default options ini: race mode+transpose+all checkboxes. Don't worry about the game_version option in the ini, the program doesn't read it and instead has its own logic to determine version.

Also rebuilt the .exe for the changes (includes yours) so people can just grab that (I also created a release with those files but since the original repo included the dist/ dir I kept it there). To aid in building future releases added the pyinstaller specfile.

Finally, added a gitignore.

Includes a better default settings ini as well (works without the file if you delete it to make your own)
not sure why I missed that setting
Sure, could use user's global ignore but why
Includes pyinstaller specfile for easier rebuilding
@Stochast1c
Copy link
Copy Markdown
Author

Unrelated to this pull request, and while I haven't really looked at it, the other request on the main repo, HotPocketRemix#3, might be a reasonable option to add in. Makes it easy to sync settings with other racers without having to rely on a sync-num that doesn't show up anywhere after you close the program.

Also unrelated, I might also look at adding a slider to change percentages for the percentage based options (like ascending weapons) for the user to modify (like the enemy randomizer).

@caerulius
Copy link
Copy Markdown
Owner

This looks great, sorry it took me so long to come around here, I wasn't maintaining this repo at all. I was actually coming back here to upload an exe since it wasn't going to be added to the other repo anytime soon! I'll merge and get a release set up. Unfortunately no one will find this when the google "Dark Souls Randomizer" but at least this is a manageable way to link people to the exe.

@caerulius caerulius merged commit c0aa125 into caerulius:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants