Remove dead fEval/fGotES eigenvalue-solve machinery - #49
Open
gavinsdavies wants to merge 1 commit into
Open
Conversation
chenel
approved these changes
Jul 31, 2026
complexsolver() filled fEval with the Hamiltonian's eigenvalues, but fEval was never read anywhere (propagation uses fHam.exp() in PropagatePath instead), so every uncached energy point paid for a ComplexEigenSolver call whose result was discarded. The paired fGotES cache flag was never checked either. Removes both members, all their writers (constructors, SetIsNuBar, BuildHms), the complexsolver method itself, and the now-dead call site in SolveHam. Per @chenel's review on #48.
gavinsdavies
force-pushed
the
unify-42-47-eigen-cleanup
branch
from
July 31, 2026 16:16
f9bd6db to
1795e1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #48 (branch
unify-42-47).Follow-up to @chenel's review comment on #48: the primary suggestion
there removed the dead
complexsolver(fHam, fEval); fGotES = true;call in
SolveHam, but noted the fix wasn't expressible as a singlesuggestion since it touches several non-adjacent sites. This PR is
that full cleanup:
OscLib/OscCalcDecayEigen.h: dropfGotES,fEvalmembers and thecomplexsolver()declarationOscLib/OscCalcDecayEigen.cxx: dropfGotES(false)from bothconstructors,
fEval.setZero()inInitializeVectors, thefGotESwrites in
SetIsNuBar/BuildHms, thecomplexsolver()definition,and the dead call site in
SolveHamNo behavior change —
fEval/fGotESwere write-only; nothing readthem.
🤖 Assisted by Claude Code (claude-sonnet-5)
Reviewed by me