Skip to content

Set php constraint#37

Closed
othercorey wants to merge 1 commit intomasterfrom
othercorey-patch-1
Closed

Set php constraint#37
othercorey wants to merge 1 commit intomasterfrom
othercorey-patch-1

Conversation

@othercorey
Copy link
Copy Markdown
Contributor

Should we do this like all other plugins?

@othercorey othercorey added this to the 1.0.0 milestone Oct 24, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2020

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage     90.09%   90.09%           
  Complexity       74       74           
=========================================
  Files             9        9           
  Lines           222      222           
=========================================
  Hits            200      200           
  Misses           22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c566064...891b8da. Read the comment docs.

@ADmad
Copy link
Copy Markdown
Member

ADmad commented Oct 24, 2020

Should we do this like all other plugins?

We could but I don't think it's necessary. The cakephp version constraint indirectly sets the PHP version contraint too for the plugin.

@markstory
Copy link
Copy Markdown
Member

I can see it being useful when a plugin requires a higher version of PHP than CakePHP does. Otherwise we can rely on the framework version being the limiter. Having this constraint everywhere is more places to update when it has to change.

@othercorey
Copy link
Copy Markdown
Contributor Author

Relying on the cakephp package constraint should work for all plugins. If a plugin requires a higher version than cakephp does then we should probably update the php requirement in cakephp instead.

@othercorey othercorey closed this Oct 25, 2020
@othercorey othercorey deleted the othercorey-patch-1 branch October 25, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants