Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage 90.09% 90.09%
Complexity 74 74
=========================================
Files 9 9
Lines 222 222
=========================================
Hits 200 200
Misses 22 22 Continue to review full report at Codecov.
|
We could but I don't think it's necessary. The cakephp version constraint indirectly sets the PHP version contraint too for the plugin. |
|
I can see it being useful when a plugin requires a higher version of PHP than CakePHP does. Otherwise we can rely on the framework version being the limiter. Having this constraint everywhere is more places to update when it has to change. |
|
Relying on the cakephp package constraint should work for all plugins. If a plugin requires a higher version than cakephp does then we should probably update the php requirement in cakephp instead. |
Should we do this like all other plugins?