fix: render data table separators as table cells#29793
Conversation
|
Welcome to Cal.diy, @AlgoArtist06! Thanks for opening this pull request. A few things to keep in mind:
A maintainer will review your PR soon. Thanks for contributing! |
|
@coderabbitai review |
✅ Action performedReview finished.
|
📝 WalkthroughWalkthroughExtracts separator-row rendering from 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/modules/data-table/components/SeparatorRowRenderer.tsx`:
- Line 3: Update the TableCell import in SeparatorRowRenderer.tsx to use the
direct TableNew source module instead of the `@calcom/ui/components/table` barrel
import.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 01c4a89a-a8d9-4381-82a6-495ad7f7e250
📒 Files selected for processing (3)
apps/web/modules/data-table/components/DataTable.tsxapps/web/modules/data-table/components/SeparatorRowRenderer.test.tsxapps/web/modules/data-table/components/SeparatorRowRenderer.tsx
|
@coderabbitai review |
✅ Action performedReview finished.
|
What does this PR do?
Data table separator rows currently place a
<div>directly inside a<tr>, producing React DOM-nesting warnings and risking hydration differences. This change renders the separator as a semantic table cell while preserving its styling, and extracts the renderer for focused regression coverage.Visual Demo (For contributors especially)
N/A — no visual change. The rendered separator element changes from
<div>to<td>.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarn vitest run apps/web/modules/data-table/components/SeparatorRowRenderer.test.tsx.<td>whose parent is the table<tr>.NODE_OPTIONS=--max-old-space-size=8192 yarn type-check:ci --force