Skip to content

Fixes the order of the displayed courses according to their config.#7

Open
mwehr wants to merge 1 commit into
call-learning:masterfrom
mwehr:FIX_SORTING
Open

Fixes the order of the displayed courses according to their config.#7
mwehr wants to merge 1 commit into
call-learning:masterfrom
mwehr:FIX_SORTING

Conversation

@mwehr
Copy link
Copy Markdown

@mwehr mwehr commented Sep 13, 2023

Hi,

This fixes the order of the displayed courses according to their configuration.

Best regards,
Mario

@danielneis
Copy link
Copy Markdown

hello, It would be better if you sort the records in the get_records_select call

@peta3000
Copy link
Copy Markdown

peta3000 commented May 29, 2024

Hii @danielneis
first of all, many thanks for your efforts in developing and maintaining this plugin!

Albeit its nice design and layout the Block plugin is HIGHLY MISSING a functionality to sort/order selected courses,
like:

  • to either sort the selected courses oneself (via CSS-Selectors like in this PR from @mwehr

or

  • like in the given PR, to have the selected courses being displayed in a successive order (which one can also adjust further via custom CSS code)

As a site-admin, I would install this plugin much more often, if it had this missing functionality.

Dear @danielneis I tried out the patch from @mwehr on a Moodle 4.1 instance and it actually worked fine, I even did not get any debug-messages since the branch did not receive any adjustments to 4.1.
So it actually works.

And dear @mwehr do you think it might be possible to implement the same functionality by using the safe_records_select call, as @danielneis suggested?

The would really profit from an added sorting functionality!!! 🙏

Cheers

p

@mwehr
Copy link
Copy Markdown
Author

mwehr commented May 30, 2024

Hi @peta3000,

See #12 for SQL verison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants