Fix issues with AJAX functionality in Moodle 4#4
Open
teruselearning wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the method customfield_multiselect\data_controller::get_value() was returning an array was causing multiple issues with core AJAX functionality returning course data.
Examples of somewhere this error was occuring is when trying to duplicate a course via 'manage courses and categories', or when trying to fetch a list of courses when adding a meta link enrolment method.
Issues also occured when using Edwiser Bridge.
The solution was to return a string of values using get_value, but preparing the data as an array when using the course edit form.
Not fully tested, but seems to fix the issues I was experiencing without causing issues with the course edit form.