Skip to content

refactor: share daemon HTTP contract helpers#846

Merged
thymikee merged 1 commit into
mainfrom
refactor/daemon-http-contract
Jun 23, 2026
Merged

refactor: share daemon HTTP contract helpers#846
thymikee merged 1 commit into
mainfrom
refactor/daemon-http-contract

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Share daemon HTTP base-path URL and auth-header helpers across proxy, remote daemon client transport, uploads, and artifact downloads.

Keep proxy/connect orchestration separate; only the low-level daemon HTTP contract moved behind focused helpers.

Validation

Focused daemon HTTP/proxy/client/upload tests passed, TypeScript passed, unit tests passed, and smoke tests passed.

Commands run:

  • ./node_modules/.bin/vitest run src/daemon/tests/http-contract.test.ts src/tests/daemon-proxy.test.ts src/utils/tests/daemon-client.test.ts src/tests/upload-client.test.ts
  • ./node_modules/.bin/tsc -p tsconfig.json --noEmit
  • ./node_modules/.bin/vitest run --project unit
  • node --test test/integration/smoke-*.test.ts

pnpm check:unit did not reach project scripts because pnpm 11.1.2 signature verification failed before execution, so I ran the equivalent unit and smoke commands directly.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.3 MB 1.3 MB -7 B
JS gzip 431.1 kB 431.1 kB +90 B
npm tarball 565.7 kB 565.8 kB +101 B
npm unpacked 1.9 MB 1.9 MB -7 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.1 ms 27.5 ms +0.4 ms
CLI --help 45.2 ms 45.1 ms -0.0 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/9919.js -46 B +59 B
dist/src/cli.js +39 B +31 B

@thymikee thymikee force-pushed the refactor/daemon-http-contract branch from ff1fd95 to 7ea6869 Compare June 23, 2026 15:41
@thymikee

Copy link
Copy Markdown
Member Author

#846 is merge-ready from review. I checked the daemon HTTP helper refactor against proxy, remote client transport, upload, and artifact download paths; all required checks are green, and there are no findings.

Residual risk is low and limited to unusual daemon base URLs with query/hash components, which were not an existing documented contract.

@thymikee thymikee merged commit 180a74b into main Jun 23, 2026
20 checks passed
@thymikee thymikee deleted the refactor/daemon-http-contract branch June 23, 2026 16:16
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-23 16:16 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant