Skip to content

refactor: deepen runner command traits#847

Merged
thymikee merged 1 commit into
mainfrom
codex/deepen-runner-command-traits
Jun 23, 2026
Merged

refactor: deepen runner command traits#847
thymikee merged 1 commit into
mainfrom
codex/deepen-runner-command-traits

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Centralize TypeScript runner command traits so read-only retry routing, readiness probes, and recent-healthy-mutation preflight skips share one module.

Adds exhaustive trait-table tests and updates CONTEXT.md to describe the Swift and TypeScript runner trait sources of truth.

Touched 8 files; scope stayed within iOS runner trait policy and vocabulary.

Validation

Ran formatter, focused iOS runner tests, lint/typecheck, and fallow audit. All passed.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.3 MB 1.3 MB +476 B
JS gzip 431.1 kB 431.4 kB +219 B
npm tarball 565.8 kB 566.1 kB +219 B
npm unpacked 1.9 MB 1.9 MB +476 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 25.9 ms 26.2 ms +0.3 ms
CLI --help 43.3 ms 43.9 ms +0.7 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/9722.js +476 B +219 B

@thymikee

Copy link
Copy Markdown
Member Author

CI is blocked on the iOS simulator smoke, and this one is past boot/runner prep: 01-settings.ad times out at step 6 waiting for label=About || label="Software Update" || text="Manage your overall setup and preferences" while the current surface is still Settings root.

Please inspect the uploaded ios-artifacts from run 28038615935, especially test/artifacts/replays-ios-simulator-smoke/.../01-settings.ad and diagnostic mqqtyqg1-1714ecba, then rerun the smoke check. Since this PR changes runner command traits/readiness policy, treat this as a blocker until the replay passes or the artifact proves it is unrelated infra noise.

@thymikee thymikee force-pushed the codex/deepen-runner-command-traits branch 2 times, most recently from cd7cca1 to 01bafe8 Compare June 23, 2026 16:11
@thymikee

Copy link
Copy Markdown
Member Author

#847 is merge-ready from review. The updated run is fully green, including iOS simulator smoke, so the earlier Settings replay timeout is superseded.

I checked the runner trait refactor against read-only retry routing, readiness probes, and recent-healthy-mutation preflight skips. The hot mutation allowlist remains tap, longPress, drag, swipe, scroll, and sequence; no findings.

@thymikee thymikee force-pushed the codex/deepen-runner-command-traits branch from 01bafe8 to 1579c05 Compare June 23, 2026 16:56
@thymikee thymikee force-pushed the codex/deepen-runner-command-traits branch from 1579c05 to ef4684e Compare June 23, 2026 16:57
@thymikee thymikee merged commit 091c7db into main Jun 23, 2026
20 checks passed
@thymikee thymikee deleted the codex/deepen-runner-command-traits branch June 23, 2026 17:00
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-23 17:00 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant