You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Verified with focused unit coverage for CLI parsing/output/progress, provider-backed doctor scenarios, Apple device ordering tests, static type/lint checks, build, and live CLI smoke for devices/doctor selection.
I do not see a routing blocker in the doctor command path: the command facet projects through the daemon registry, and the Android probes still run under the request-scoped provider path via the adb executor scope.
One thing I would address before merge: src/daemon/handlers/session-doctor.ts lands as a 571-line handler and mixes option parsing, session/device selection, app discovery, Android foreground/reverse/animation probes, RN overlay checks, Metro probing, output ordering, and progress emission. The repo agent guide asks us to extract focused submodules once implementation files grow past 500 LOC. Please split the probe families out before merge, for example keeping session-doctor.ts as the orchestrator and moving Android/Metro/RN checks into focused session-doctor-* modules or a small doctor-checks/ group. That will make follow-up doctor checks reviewable without growing the handler further.
Re-check after the latest push: this still needs the split before I would call it merge-ready. src/daemon/handlers/session-doctor.ts is now 599 LOC, and the Android/Metro/RN/session/device checks are still all in that handler. CI is green and the route/provider coverage looks fine, but the previous maintainability finding is unresolved.
GitHub now reports this branch as conflicted against main after #884 merged. Please rebase, resolve the conflicts, and reply with what changed plus any validation you reran. I am holding re-review until the branch is clean again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a read-only doctor command for RN/Expo/Metro preflight checks, with progressive human output and JSON evidence.
Closes #874
Validation
Verified with focused unit coverage for CLI parsing/output/progress, provider-backed doctor scenarios, Apple device ordering tests, static type/lint checks, build, and live CLI smoke for devices/doctor selection.