fix: enforce device leases for daemon sessions#886
Closed
thymikee wants to merge 3 commits into
Closed
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
Member
Author
|
Closing as superseded by #890, which integrates the lease contract, proxy connect, session admission/expiry, and diagnostics work. Please continue review there. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind daemon sessions to lease ownership metadata so follow-up commands can admit against the stored session lease, heartbeat activity, release on close, and reclaim expired leased sessions.
Adds shared lease-scope merge/proxy validation helpers and keeps
DeviceLeaseas the daemon registry vocabulary withSimulatorLeaseas a compatibility alias.Validation
pnpm formatpassed.pnpm typecheckpassed.pnpm exec vitest run src/daemon/__tests__/request-execution-scope.test.ts src/daemon/__tests__/request-router-open.test.ts src/daemon/__tests__/request-router-lock-policy.test.ts src/daemon/__tests__/session-store.test.tspassed, 48 tests.pnpm check:unitwas attempted twice: sandboxed run failed with localhostlisten EPERM; escalated run reduced to five unrelated platform/exec timeout or mocked-tool failures outside the Plan 003 path.