Skip to content

fix(android): honor maxLines/numberOfLines in text renderer #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
V3RON merged 2 commits into from
May 4, 2026
+11 −1
Merged

fix(android): honor maxLines/numberOfLines in text renderer #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25af5d2
fix(android): honor maxLines/numberOfLines in text renderer
hsravat-4590 Apr 30, 2026
4f01bc3
chore: add changeset
V3RON May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-android-max-lines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'voltra': patch
---

Fix `maxLines` text truncation on Android widgets so line limits apply correctly.
7 changes: 6 additions & 1 deletion packages/voltra/android/src/main/java/voltra/glance/renderers/TextAndImageRenderers.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ fun RenderText(
val text = extractTextFromNode(element.c)
val renderAsBitmap = element.p?.get("renderAsBitmap") as? Boolean ?: false
val textStyle = resolvedStyle?.text ?: voltra.styling.TextStyle.Default
val maxLines =
(element.p?.get("maxLines") as? Number)?.toInt()
?: textStyle.lineLimit
?: Int.MAX_VALUE

if (renderAsBitmap && textStyle.fontFamily != null) {
val context = LocalContext.current
Expand All @@ -67,6 +71,7 @@ fun RenderText(
val bitmapTextStyle =
textStyle.copy(
color = textStyle.color?.let { VoltraColorValue.Static(it.resolveColor(context)) },
lineLimit = maxLines,
)
// Use screen width as max constraint
val maxWidthPx = (context.resources.displayMetrics.widthPixels * 0.9f).toInt()
Expand Down Expand Up @@ -95,7 +100,7 @@ fun RenderText(
}

val glanceTextStyle = textStyle.toGlanceTextStyle()
Text(text = text, modifier = finalModifier, style = glanceTextStyle)
Text(text = text, modifier = finalModifier, style = glanceTextStyle, maxLines = maxLines)
}

@Composable
Expand Down
Loading