Implement enhanced column manipulation functionality#29
Open
pydsigner wants to merge 1 commit intocalumk:mainfrom
Open
Implement enhanced column manipulation functionality#29pydsigner wants to merge 1 commit intocalumk:mainfrom
pydsigner wants to merge 1 commit intocalumk:mainfrom
Conversation
Author
|
I tried doing the movement with SortableJS but there's a whole bunch of jank with the interactions among the different editorJS instances so I bailed on that... |
Owner
|
Hmm. I use https://github.com/kommitters/editorjs-drag-drop with some of my projects, but that has just been end-of-life so I wonder if there is a way of building a whole new drag-drop plugin that also supports the columns.... |
Author
|
I can try merging your event propagation changes in and see if that makes the DnD work better. The problem I was seeing is that the built-in drag-and-drop behavior of EditorJS was firing along with the SortableJS event and breaking everything. I was having a hard time finding where I could stop those propagations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know what you think about this. It replaces the current tweak-based column management with overlays for moving, inserting, and deleting columns. I think it's a more natural approach. As it stands, it needs some visual work, but I wanted to get it in front of you and see what you think of the concept. Here's a screenshot of the updated demo:
