Added partial support for dBase level 7#12
Open
marmol-dev wants to merge 3 commits intocalvinmetcalf:masterfrom
Open
Added partial support for dBase level 7#12marmol-dev wants to merge 3 commits intocalvinmetcalf:masterfrom
marmol-dev wants to merge 3 commits intocalvinmetcalf:masterfrom
Conversation
calvinmetcalf
requested changes
Jul 5, 2017
Owner
calvinmetcalf
left a comment
calvinmetcalf
left a comment
There was a problem hiding this comment.
what are the actual changes, how different are the 2 types, I'm mainly just seeing some new types and the deleted flag
index.js
Outdated
| var header = dbfHeader(buffer); | ||
|
|
||
| if (header.dBaseVersion === 'level7') { | ||
| return parseLevel7.apply(this, arguments) |
Owner
There was a problem hiding this comment.
return parseLevel7(buffer, encoding);
| var out = {}; | ||
|
|
||
| switch(data[0] & 0x07) { | ||
| case 0x03: |
Owner
There was a problem hiding this comment.
lets not get all fancy here, 0x03 is also know as...3, same with 0x07 and 0x04
| var deleted; | ||
| deleted = buffer.readUInt8(offset) == 0x2A | ||
| offset++ | ||
| out['@deleted'] = deleted |
Owner
There was a problem hiding this comment.
ok so this is a field that's going to be showing up in records, if it's deleted shouldn't it actually just skip this record?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added partial support for dBase level 7.
Some header properties are ignored.