Develop #14
Open
Develop #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* split client out further into more digestable parts * simplify, factor business logic out of cmd package and into upload and download packages * rearrange some more stuff. Start testing * fix some bugs * abstract out token handling into lowest level request interface * fix a bunch of bugs * adds very minimal docs
* fix missing error check * Initial plan * Fix error wrapping to preserve error chain using fmt.Errorf with %w Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com> * Update PR description with completion status Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com> * Add /bin/ to .gitignore and remove accidentally committed binary Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com> --------- Co-authored-by: Brian Walsh <brian@bwalsh.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
* MinChunkSize: 10MB * fix:improve-multipart #18 * improve OptimalChunkSize.scaleLinear * adds optimal-chunk-size * table-driven tests GetLfsCustomTransferInt * Address PR review comments: fix naming, formatting, and test coverage * Add logging for git config errors and improve documentation structure * Fix spelling: terrabytes → terabytes * adds ProgressEvent * Fix nil pointer dereferences and duplicate progress events - Added nil check for req.Progress in multipart.go to prevent panic - Removed duplicate progress event in singleFile.go (Finalize already emits) - Fixed concurrent BytesSoFar calculation using atomic counter for monotonicity * adds tests * add noop ProgressCallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.