Skip to content

feat: added side queue position setting#22

Open
nanophilip wants to merge 3 commits intocambridge-stacker:mainfrom
nanophilip:side-queue-vertical-position-setting
Open

feat: added side queue position setting#22
nanophilip wants to merge 3 commits intocambridge-stacker:mainfrom
nanophilip:side-queue-vertical-position-setting

Conversation

@nanophilip
Copy link
Contributor

The next piece queue on the side when positioned near the top is hard to see when the eyes need to stay focused on the grid at high gravity.

Perhaps the setting could be expanded to center the queue vertically on the side depending on how many pieces are visible in the queue in a given game mode.

The next piece queue on the side when positioned near the top is hard to
see when the eyes need to stay focused on the grid at high gravity.

Perhaps the setting could be expanded to center the queue vertically on
the side depending on how many pieces are visible in the queue in a
given game mode.
@Rexxt Rexxt closed this Jul 19, 2025
@nanophilip
Copy link
Contributor Author

Please let me make sure there is no misunderstanding. As I can see there is a setting to have the next piece queue either on top or on the side of the grid. That setting is called 'Next position' with options 'Top' and 'Side'. I added another setting that can change the vertical position of the queue when it is set to 'Side'. Does that already exist?

Or if having two settings is confusing, perhaps a still better method would be to have three options under one setting for the queue?

  1. Top
  2. Side (vertically near the top)
  3. Side (vertically centered)

@Rexxt Rexxt reopened this Jul 19, 2025
@Rexxt
Copy link
Contributor

Rexxt commented Jul 19, 2025

apologies for the misunderstanding, I'll get back to you later

@nanophilip
Copy link
Contributor Author

This needs more work. Some game modes display text to the right of the frame. Space which is invaded by the next piece queue if it is positioned too low vertically.

@nanophilip nanophilip closed this Jul 25, 2025
Mode Survival AX did not respect config.side_next. All other modes
already did.

This functionality already existed in all other modes.
tetris.mode.gamemode is already drawing 'NEXT' text. In addition,
survival_ax did hardcode 'NEXT' text into top position. Without
respecting config.side_next like all other modes do.
@nanophilip nanophilip reopened this Jul 30, 2025
@nanophilip
Copy link
Contributor Author

Survival AX was the only mode that did not respect config.side_next. Now it does. Text is drawn further to the right. And the next piece queue when set to the side does not overlap with any text.

@Rexxt
Copy link
Contributor

Rexxt commented Aug 6, 2025

this will need corresponding changes in the modpack, in which most modes currently do not account for queue position

@Rexxt Rexxt requested a review from Tetro48 August 6, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants