Add Rust 1.60 as the MSRV to Cargo.toml#2
Open
sunshowers wants to merge 2 commits intocameron1024:masterfrom
Open
Add Rust 1.60 as the MSRV to Cargo.toml#2sunshowers wants to merge 2 commits intocameron1024:masterfrom
sunshowers wants to merge 2 commits intocameron1024:masterfrom
Conversation
unarray uses an API that requires Rust 1.60, so we can go ahead and update the Rust edition to 2021.
Currently, this crate does not indicate an MSRV but uses an API, `MaybeUninit::assume_init_drop`, that was added with Rust 1.60. Indicate that this crate is compatible with Rust 1.60 and above. Also add CI against the MSRV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I have a library for which the MSRV is Rust 1.56 -- unarray, which is now used by proptest, got pulled in and the project failed to compile.
I've now checked in a Cargo.lock, but I thought it would be good to have Rust 1.60 be explicitly declared as the MSRV.