refactor(assemble): split built-in assemblers by physics - #37
Open
kilickursat wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kursat Kilic <kilic_kursat@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the built-in assembler layout from the monolithic
tensormesh/assemble/builtin.pymodule into abuiltin/package organized byphysics category.
The new hierarchy is:
Geomechanics lives under the solid family:
Scope
builtin/fluid/builtin/solid/builtin/electromagnetic/namespacetensormesh.assembletensormesh.assemble.builtintensormesh.assemble.builtin.solidOut of scope
.potranslation updatesValidation
Ran locally:
pytest tests/assemble/test_builtin_imports.py -vpytest tests/assemble -vpytest tests/functional/test_drucker_prager.py -vpytest tests/material/test_frictional_material.py -vpytest tests/assemble/test_drucker_prager_plasticity.py -vpytest tests/assemble/test_drucker_prager_triaxial_example.py -vpytest tests/assemble/test_drucker_prager_footing_example.py -vpython examples/solid/geomechanics/drucker_prager_triaxial/drucker_prager_triaxial.py --no-plot --steps 16python examples/solid/geomechanics/drucker_prager_footing/drucker_prager_footing.py --no-plot --steps 6 --chara-length 0.60cd docs && make htmlcd docs && make zhAlso verified import compatibility for:
Notes
This is a structure-only refactor. The previous public import paths are preserved
through
builtin/__init__.pyandtensormesh/assemble/__init__.py.