Update build process#47
Open
isanchez-c2c wants to merge 7 commits intomainfrom
Open
Conversation
- move Dockerfile so that it can run targets from Makefile - update docker build paths in Makefile - add front-server to docker-compose : is it needed to run automated front tests
to be consistent with git repo name and docker image name
RemiDesgrange
approved these changes
Aug 6, 2021
Contributor
RemiDesgrange
left a comment
RemiDesgrange
left a comment
There was a problem hiding this comment.
See my minor comment, otherwise, LGTM, 
Comment on lines
17
to
+18
| - name: Backend packages | ||
| run: docker run camptocamp/drealcorse-reports-app-tools:latest pip freeze | ||
| run: docker run camptocamp/featurereports-backend-tools:1.0 pip freeze |
Contributor
There was a problem hiding this comment.
Why is this step needed anyway?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.