update module and metadata to support puppet8#20
Open
jiayuchen888 wants to merge 2 commits into
Open
Conversation
jiayuchen888
force-pushed
the
jch_puppet8_support
branch
5 times, most recently
from
335d5cf to
a64bc0f
Compare
jiayuchen888
force-pushed
the
jch_puppet8_support
branch
from
a64bc0f to
dedf0c7
Compare
JGodin-C2C
reviewed
Mar 27, 2026
JGodin-C2C
reviewed
Mar 27, 2026
JGodin-C2C
requested changes
Mar 27, 2026
JGodin-C2C
reviewed
Jun 11, 2026
| value => 'on', | ||
| ; | ||
| 'archive_command': | ||
| value => '/usr/local/bin/archive_command.sh /usr/local/bin/exporter.env %p', |
Member
There was a problem hiding this comment.
My two cents: I think we should change the exporter.env path as this should not be in the bin directory. i think somewhere in /var/ or /etc/ (as it is configuration ) would be more relevent.
If that makes any sense ?
Contributor
Author
There was a problem hiding this comment.
I prefer /etc if you want to move it somewhere else
Member
There was a problem hiding this comment.
I agree.
Do you want to do that on this pr or open another one ?
Contributor
Author
There was a problem hiding this comment.
I can propose on this pr.
jiayuchen888
force-pushed
the
jch_puppet8_support
branch
4 times, most recently
from
5ba6cb0 to
6b957b1
Compare
JGodin-C2C
reviewed
Jun 11, 2026
| String $backup_prefix = '', | ||
| Optional[Integer] $backup_fuse_threshold_gbytes = undef, | ||
| Stdlib::Absolutepath $destination = '/usr/local/bin', | ||
| Stdlib::Absolutepath $config_path = '/etc/exporter.env', |
jiayuchen888
force-pushed
the
jch_puppet8_support
branch
from
6b957b1 to
8006406
Compare
jiayuchen888
force-pushed
the
jch_puppet8_support
branch
from
8006406 to
2d44f60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: