Allow intermediate geographies#1
Conversation
|
@nick-fournier Thanks for looking into this, but it looks like it's still failing with the same error that I was getting before where it isn't reading in the geographies from the correct settings file. |
|
Hi @JoeJimFlood I was out on PTO last week, But I see this now and will pick this up. |
|
@JoeJimFlood Okay I think I figured it out. I think its a transient pipeline cache issue when tests run in different order, so it was one of those "works on my machine". However, the travis CI seems to be stuck in a queue. Not sure if you're able to kick it off. |
|
Okay the intermediate zone test passed but some others broke... 🥲 |
Co-authored-by: Copilot <copilot@github.com>
9371760 to
8e20cbf
Compare
|
Okay I found the issues.
Just working through those now, but I'm confident it should pass. Note: We could/should probably just delete the .travis.yml and rely on github actions workflow, because that's what is being used upstream on the main repo, but if you guys are using it that's fine. |
|
It looks like the test was successful. Thanks for your help on this! |
2c11788
into
camsys:allow_intermediate_geographies

Hey @JoeJimFlood I made some edits that should fix the test issues. Couldn't push to your repo so here's a PR to your PR :)
Data type consistency improvements:
integer_weightcolumns tonp.int64in both thereshape_resultanddo_sequential_integerizingfunctions inpopulationsim/integerizing/wrappers.pyto ensure consistent integer type handling. [1] [2]expand_households.py, modify the assignment ofhh_idsto use.valuesinstead oflist()to preserve theint64numpy array dtype for household IDs. (This was the real bugger)Code cleanup:
numpyandpandas) fromtests/test_intermediate_geography.pyfor cleaner test files.