fix(ci): don't cancel healthy jobs on sibling infra failures - #267
Merged
Conversation
The failfast watcher and cancel-on-failure steps were treating all job failures equally — a checkout timeout on one runner would cancel tests running normally on other runners. Now: 1. ci-failfast-watcher.sh: only kills the current job when a sibling has a real test/lint failure, not infra failures (checkout, install) 2. ci.yaml cancel steps: use step outcome IDs so only test step failures trigger workflow cancellation, not checkout/install failures 3. ci-auto-retry.yaml: retries when any infra failure exists, even if mixed with real test failures (real failures will just fail again) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Candle AI ReviewScope
FindingsNo invariant violations detected. PR Completeness
Risk: LowCI/CD-only changes with no source modifications; no candle invariants are in scope. Full review at commit 10a72a4 (2026-03-25 04:55 UTC) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if: failure()toif: steps.<test-step>.outcome == 'failure', so checkout/install failures don't cascade-cancel the entire workflow.Problem
PR #222 had 5 failed jobs: 3 real test failures + 2 infra failures (checkout). The old logic:
Test plan
🤖 Generated with Claude Code