Skip to content
This repository was archived by the owner on Nov 21, 2024. It is now read-only.

Add a new plug in to add running MUC's and private chats with roster items#165

Open
jansing wants to merge 17 commits intocandy-chat:masterfrom
jansing:master
Open

Add a new plug in to add running MUC's and private chats with roster items#165
jansing wants to merge 17 commits intocandy-chat:masterfrom
jansing:master

Conversation

@jansing
Copy link

@jansing jansing commented Aug 27, 2016

An extension/fork of the available-rooms plugin to also let the user add private chats with people from the rosters.
Also fix available-chats plugin on the way.

@benlangfeld
Copy link
Member

This perhaps satisfies the request in #166 ?

@benlangfeld
Copy link
Member

@maennchen Could you perhaps review this (it's a change to your plugin)?

@sbrl
Copy link

sbrl commented Oct 17, 2016

Yep, that works a treat 😄

It does however look a bit odd with two new tab buttons (since I have a new tab button for rooms too), but that's just a minor detail.

@jansing
Copy link
Author

jansing commented Oct 17, 2016

The "+" Button in AvailableChat should contain both MUC-Rooms and Roster contacts.
If not, it's a bug ;-).
So its kind of an extension of AvailableRooms. The latter should not be needed in additionally.

@sbrl
Copy link

sbrl commented Oct 17, 2016

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants