Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(api): Docker, env loading, secrets removal, route cleanup (Phase 3 — T3.0–T3.4) #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/figma-phase-e-drift
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(api): Docker, env loading, secrets removal, route cleanup (Phase 3 — T3.0–T3.4) #44
Changes from all commits
12f016d6ebe6c61fd41d5File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docker-run task uses --env-file .env.local which makes vars available inside the container, but BAUER_CREDENTIALS_PATH in the -v mount is expanded by the host shell. The Taskfile header instructs users to set up env vars before running. Adding a dotenv directive would load secrets into all tasks (build, test, lint) which is not desirable. Current approach — documented env setup + --env-file for the container — is the right trade-off for a dev-only task.