apport-unpack: fix mypy complaint in unpack_report_to_directory#605
Open
bdrung wants to merge 1 commit into
Open
apport-unpack: fix mypy complaint in unpack_report_to_directory#605bdrung wants to merge 1 commit into
bdrung wants to merge 1 commit into
Conversation
bdrung
force-pushed
the
apport-unpack-bytes
branch
from
931fd77 to
b71e0d6
Compare
bdrung
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
=======================================
Coverage 84.54% 84.54%
=======================================
Files 104 104
Lines 21028 21029 +1
Branches 3219 3219
=======================================
+ Hits 17779 17780 +1
Misses 2809 2809
Partials 440 440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mypy will complain if `ProblemReport` will get type hints: ``` error: Argument 1 to "write" of "BufferedWriter" has incompatible type "bytes | CompressedFile | CompressedValue | tuple[Any, ...]"; expected "Buffer" [arg-type] ``` The problem report is loaded with `binary=True` or `binary=False`. In both cases this should result in the values to be either `str` or `bytes`. So add an `isinstance` assertion for that.
bdrung
force-pushed
the
apport-unpack-bytes
branch
from
b71e0d6 to
f2bcbf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypy will complain if
ProblemReportwill get type hints:The problem report is loaded with
binary=Trueorbinary=False. In both cases this should result in the values to be eitherstrorbytes. So add anisinstanceassertion for that.